Add scale out functionality for SNO Cluster #689
Conversation
|
Skipping CI for Draft Pull Request. |
|
/cc @akrzos |
afcollins
left a comment
afcollins
left a comment
There was a problem hiding this comment.
Thank you! Looking good. Left some comments..
|
/test ? |
|
@sraviteja-maker: The following commands are available to trigger required jobs: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test deploy-mno-scaleout |
|
/test deploy-sno |
|
/test deploy-sno |
…tlag into scale_out_sno_cluster
|
/test deploy-sno |
|
/test deploy-mno-scaleout |
|
/test deploy-sno |
|
/test deploy-mno-scaleout |
|
@sraviteja-maker Looks like we have a merge conflict now, are you able to resolve this? |
@akrzos Yeah...I am able to resolve this. |
akrzos
left a comment
akrzos
left a comment
There was a problem hiding this comment.
My previous review, I had not noticed the inclusion of a new hostvar called lab_dhcp_interface, I think we should just use the existing hostvar called lab_interface to avoid var sprawl, please see comments unless there is a need to include yet another variable.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrzos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 966a67f
into
redhat-performance:main
6 participants
This functionality will help us to scale out the existing SNO Cluster where we can create clusters with SNO+1,SNO+2...SNO+N Deployment models for our internal testing.
It will be very useful for getting around the lab resource constraints.